fix: nil pointer dereferences in private cluster reconciliation (v1.11.0-beta.0) #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Patches CAPG v1.11.0-beta.0 to fix nil pointer dereferences when creating/reconciling private GKE clusters with PSC (Private Service Connect) mode - i.e., when
enablePrivateEndpoint: truewithout specifyingcontrolPlaneCidrBlock.Fixes
1. Creation path (NetworkConfig initialization)
In
createCluster,cluster.NetworkConfig.DefaultEnablePrivateNodeswas accessed beforeNetworkConfigwas initialized.Changes:
NetworkConfigbefore accessingDefaultEnablePrivateNodesEnablePrivateNodesonPrivateClusterConfigto match (GCP SDK requires both fields to have the same value)2. Reconciliation path (DesiredControlPlaneEndpointsConfig initialization)
In
checkDiffAndPrepareUpdate,clusterUpdate.DesiredControlPlaneEndpointsConfig.IpEndpointsConfig.AuthorizedNetworksConfigwas assigned without initializing the parent structs.Changes:
DesiredControlPlaneEndpointsConfigandIpEndpointsConfigbefore assigningAuthorizedNetworksConfigRelated upstream issues
Image
Built and pushed to Artifact Registry:
Rebuild instructions
Usage in CAPI Operator
In
argocd/applicationsets/capi-operator.yaml:GCPManagedControlPlane requirements
When using private endpoint,
master_authorized_networks_configmust be set in the GCPManagedControlPlane spec:Prerequisites
Grant Artifact Registry read access to the management cluster's compute service account: